Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement phase #68

Merged
merged 7 commits into from
Feb 21, 2020
Merged

Implement phase #68

merged 7 commits into from
Feb 21, 2020

Conversation

mlin865
Copy link
Contributor

@mlin865 mlin865 commented Feb 13, 2020

No description provided.

@rchristie
Copy link
Member

Some of the test answers have changed – is this because the addition of phase has slightly changed the zero phase answer?

@mlin865
Copy link
Contributor Author

mlin865 commented Feb 21, 2020

Yes, this is due to the different method I applied to calculate node locations now and given that the results are still quite close to the original values, I am quite happy with the changes.

@rchristie
Copy link
Member

You'll need to catch up again to get other commits.

@rchristie rchristie merged commit 3550ddb into ABI-Software:master Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants