Replace heart atria, improve parameters for all species #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow end derivatives to be specified when creating hermite curves on a track surface. New element layout on anterior and posterior of left atrium. Smooth a lot of derivatives.
Adjust vena cavae. Add new functions for sampling elements on curves, with smoothly varying sizes between end derivative magnitudes. Use when sampling curves from track surface. Tidy up annulus mesh sampling and smoothing.
Reduce default elements over atria to 6.
Fix spacing of elements around atria.
Configure ostium scaffold by number of elements around ostium, not vessels. Add pulmonary vein annotation groups for 1, 2 or 3 vessels, left and right.
Make ostium vessel angles relative to local normals, not centre normal.
Some glitches remain, including one element hole.
Fix derivative smoothing around left atrium.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.