Mouse colon #54
Merged
Mouse colon #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olon segment profile
rchristie
requested changes
Jul 1, 2019
| meshrefinement.refineAllElementsCubeStandard3d(refineElementsCountAround, refineElementsCountAlong, refineElementsCountThroughWall) | ||
| return meshrefinement.getAnnotationGroups() | ||
|
|
||
| def getColonSegmentInnerPoints0TC(region, elementsCountAroundMZ, elementsCountAroundNonMZ, elementsCountAlongSegment, |
There was a problem hiding this comment.
Name wasn't immediately obvious, rename:
0TC -> NoTeniaColi, or SimpleMesentery?
|
|
||
| @classmethod | ||
| def getOptionValidScaffoldTypes(cls, optionName): | ||
| if optionName == 'Central path': | ||
| return [ MeshType_1d_path1 ] | ||
| if optionName == 'Segment profile': | ||
| return[ MeshType_3d_colonsegmentsimplemesentery1, |
There was a problem hiding this comment.
Minor. Insert space after return.
| haustrumInnerRadiusFactor = options['Haustrum inner radius factor'] | ||
| haustrumLengthEndDerivativeFactor = options['Haustrum length end derivative factor'] | ||
| haustrumLengthMidDerivativeFactor = options['Haustrum length mid derivative factor'] | ||
| widthTC = options['Tenia coli width'] |
There was a problem hiding this comment.
Make consistent with other variables, where width, thickness is last, also with naming conventions I use in heart (including variables starting with lower case, types with upper case):
tcWidth
tcThickness
| surface along mid-length of segment. | ||
| :return coordinates, derivatives on inner surface of a colon segment. | ||
| """ | ||
| MZGroup = AnnotationGroup(region, 'mesenteric zone', FMANumber = 'FMANumber unknown', lyphID = 'Lyph ID unknown') |
There was a problem hiding this comment.
Use standard of variables starting with lower case.
| @@ -195,17 +205,17 @@ def generateMesh(cls, region, options): | |||
| meshrefinement.refineAllElementsCubeStandard3d(refineElementsCountAround, refineElementsCountAlong, refineElementsCountThroughWall) | |||
| return meshrefinement.getAnnotationGroups() | |||
|
|
|||
| def getColonHaustraSegmentInnerPoints(elementsCountAroundTC, elementsCountAroundHaustrum, elementsCountAlongHaustrum, widthTC, radius, | |||
| cornerInnerRadiusFactor, haustrumInnerRadiusFactor, haustrumLengthEndDerivativeFactor, haustrumLengthMidDerivativeFactor, haustrumLength): | |||
| def getColonSegmentInnerPoints3TC(region, elementsCountAroundTC, elementsCountAroundHaustrum, elementsCountAlongSegment, widthTC, radius, | |||
There was a problem hiding this comment.
3TeniaColi, or is it going to take number of tenia coli as an argument once you do pig? Can always:
|
Changes made as requested. |
rchristie
approved these changes
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.