Texture coordinates #46
Conversation
| if self._useCrossDerivatives: | ||
| eft.setTermNodeParameter(n*4 + 4, 1, ln, Node.VALUE_LABEL_D2_DS1DS2, 2) | ||
|
|
||
| assert eft.validate(), 'eftfactory_bicubichermitelinear.createEftFlattenTube: Failed to validate eft' |
There was a problem hiding this comment.
Function name difference in assert.
| def createEftOpenTube(self): | ||
| ''' | ||
| Create a basic bicubic hermite linear element template for elements | ||
| along boundary where a tube is opened for a flat preparation. Retain node |
There was a problem hiding this comment.
Document: opened on xi1 = 1. Could eventually have 6 variants.
scaffoldmaker/utils/tubemesh.py
Outdated
| d1Texture.append(d1) | ||
| d2Texture.append(d2) | ||
|
|
||
| nodeIdentifier = nextNodeIdentifier |
There was a problem hiding this comment.
Change 'next' to 'first' in nextNodeIdentifier, nextElementIdentifier throughout this function as it's clearer.
scaffoldmaker/utils/tubemesh.py
Outdated
| textureCoordinates.setNodeParameters(cache, -1, Node.VALUE_LABEL_D2_DS1DS2, 1, zero) | ||
| textureCoordinates.setNodeParameters(cache, -1, Node.VALUE_LABEL_D2_DS1DS2, 2, zero) | ||
| nodeIdentifier = nodeIdentifier + 1 | ||
| elif (n+1)%(elementsCountAround+1) > 0: |
scaffoldmaker/utils/tubemesh.py
Outdated
| textureCoordinates.setNodeParameters(cache, -1, Node.VALUE_LABEL_D2_DS1DS2, 1, zero) | ||
| nodeIdentifier = nodeIdentifier + 1 | ||
|
|
||
| # create texture coordinate elements |
There was a problem hiding this comment.
Change comment to 'define texture coordinates field over elements
(no new elements are being created)
scaffoldmaker/utils/tubemesh.py
Outdated
|
|
||
| elementtemplate1 = mesh.createElementtemplate() | ||
| elementtemplate1.setElementShapeType(Element.SHAPE_TYPE_CUBE) | ||
| elementtemplate1.defineField(textureCoordinates, -1, eftTexture) |
scaffoldmaker/utils/tubemesh.py
Outdated
| @@ -243,6 +243,107 @@ def generatetubemesh(region, | |||
| result = element.setNodesByIdentifier(eft, nodeIdentifiers) | |||
| elementIdentifier = elementIdentifier + 1 | |||
|
|
|||
| # Create texture coordinates | |||
There was a problem hiding this comment.
Define texture coordinates field
scaffoldmaker/utils/tubemesh.py
Outdated
| u = [ 1.0 / elementsCountAround * n1, | ||
| 1.0 / elementsCountAlong * n2, | ||
| 1.0 / elementsCountThroughWall * n3] | ||
| d1 = [1.0 / elementsCountAround, 0.0, 0.0] |
There was a problem hiding this comment.
d1 and d2 are not functions of n1, n2 or n3, so no need to calculate and store.
Eventually we may have variability around, but I expect we'll be consistent all the way along, or within each segment.
Personally I'd just store the variation with n1 and n3, then define the rest in the node loop.
Only cache coordinates if there is a performance gain from shared calculation.
scaffoldmaker/utils/tubemesh.py
Outdated
| textureCoordinates.setNodeParameters(cache, -1, Node.VALUE_LABEL_D_DS1, 1, d1Texture[n]) | ||
| textureCoordinates.setNodeParameters(cache, -1, Node.VALUE_LABEL_D_DS2, 1, d2Texture[n]) | ||
| endIdx = n + elementsCountAround | ||
| textureCoordinates.setNodeParameters(cache, -1, Node.VALUE_LABEL_VALUE, 2, uTexture[endIdx]) |
There was a problem hiding this comment.
All the code in the if and else clauses is the same except setting the second version for the last nodes. Put the common code in one place. i.e. at the end:
if n == 0:
textureCoordinates.setNodeParameters(cache, -1, Node.VALUE_LABEL_VALUE, 2, uTexture[endIdx])
textureCoordinates.setNodeParameters(cache, -1, Node.VALUE_LABEL_D_DS1, 2, d1Texture[endIdx])
textureCoordinates.setNodeParameters(cache, -1, Node.VALUE_LABEL_D_DS2, 2, d2Texture[endIdx])
if useCrossDerivatives:
textureCoordinates.setNodeParameters(cache, -1, Node.VALUE_LABEL_D2_DS1DS2, 2, zero)
scaffoldmaker/utils/tubemesh.py
Outdated
|
|
||
| nodeIdentifier = nextNodeIdentifier | ||
| for n in range(len(uTexture)): | ||
| if n%(elementsCountAround+1) == 0.0: |
There was a problem hiding this comment.
== 0, not a floating point.
Also, I like spaces around operators % and +.
That said, I would loop as follows:
for n3 in range(elementsCountThroughWall + 1):
for n2 in range(elementsCountAlong + 1):
for n1 in range(elementsCountAround):
... and then compute coordinates from those precalculated around one slice.
No description provided.