Network tube #240
Merged
Network tube #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supply construction object to interactive functions. Requires simultaneous update to Scaffold Creator. Make network layout structure hidden and editable only from new interactive function. Support Hermite serendipity basis for tube bifurcation and track surface generation.
Improve loop handling in TrackSurface.
TrackSurface findNearestPosition now converges with oscillations for distant points. TrackSurface generateMesh fixed for loop1.
Support cross derivatives in TrackSurface.
Fix finding nearest parameter point when one is 0 distance away.
Jolt xi location to get out of local minimum.
Stay sticky on boundary for 4 iterations. Solve quadratic to get next estimate of intersection for all cases now. Starting point for finding intersection curve is not based on element centres.
Fix trim surfaces when distorting due to convergence. Make serendipity basis tube network option. Fix network mesh node templates.
Add network layout interactive function for scaling side derivatives. Add all network layout default parameters for tube network. Put try/except around tube bifurcation tree generation in case of exception due to crazy inputs. Insert absent derivatives into TrackSurface intersection curve. Reduce incidents of non-convergence of TrackSurface.getNearestPoint() by incrementally reducing MAX_MAG_DXI. Add tube network test.
Add function for assigning inner coordinates as a function of outer coordinates. Add missing d13 to sphere cube network layout and update test answers.
Fix single segment loop networks. Add loop tube network parameter set. Spread out default network coordinates better, and reduce side derivatives. Redefine bifurcation parameter set to be symmetric.
Can set assign any coordinates from any other coordinates. Remove scale utility code. Fix left handed coordinate system for loop network.
mlin865
suggested changes
Nov 22, 2023
mlin865
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.