-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bladder coordinates #235
Merged
Merged
Bladder coordinates #235
Changes from 32 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
19bc323
Changed the wall thickness amounts.
zekh167 16946f1
Changed the material central path's coordinates and derivatives to re…
zekh167 a5c6efc
Making the nodes from outer surface to inner surface.
zekh167 5e3dde1
Put the markers on inner surface.
zekh167 daec000
Changed the wall thicknesses.
zekh167 7b954e2
changed the test for bladder.
zekh167 e0e6792
Changed the function to get the right coordinates and derivatives.
zekh167 d9ee349
Changed the function name and added the outward parameter.
zekh167 a35fd20
Changed the function name and added the outward parameter.
zekh167 888d585
Changed the function name and added the outward parameter.
zekh167 899d888
Changed the function name and added the outward parameter.
zekh167 d3feb2a
Changed the function name and added the outward parameter.
zekh167 d0ff653
Changed the function name and added the outward parameter.
zekh167 fca492f
Changed the function name and made the required changes to apex.
zekh167 7355186
Updated the bladder test.
zekh167 13e8ac2
Removed the 'Ureter position around' from the visible options.
zekh167 e2b7eac
Fixed the issues with Hermite through wall for material coordinates.
zekh167 690bbd6
Fixed the markers location.
zekh167 81f60f3
Updated the bladder test.
zekh167 0902725
Moved the apex to outside surface.
zekh167 0145808
Updated bladder test.
zekh167 9d2386d
Changed two parameters for Cat and Material.
zekh167 b6ba03c
Changed the material wall thickness.
zekh167 fedb407
Updated.
zekh167 2a703c5
Updated cecum test.
zekh167 3cef73e
Updated colon test.
zekh167 8d05ff8
Updated colon segment test.
zekh167 8aa67dc
Updated esophagus test.
zekh167 181202d
Updated small intestine test.
zekh167 56e932e
Updated the extrudeSurfaceCoordinates function.
zekh167 b6c49d0
Updated the colonsegment test.
zekh167 165064e
Fixed the d1.
zekh167 f89c5d9
Fixed d3.
zekh167 0bbbe97
Updated bladderurethra test with main branch.
zekh167 86b3538
Updated cecum test with main branch.
zekh167 ddc85dd
Updated colon test with main branch.
zekh167 ea67b23
Updated colonsegment test with main branch.
zekh167 ee141f1
Updated esophagus test with main branch.
zekh167 101c355
Updated small intestine test with main branch.
zekh167 ab7cd5c
Minor change.
zekh167 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can't just negate the wall thickness and pass to this function. What you're getting is elements with negative volume, with xi0 on the outside and xi1 on the inside. This also means your lumen/serosa annotations appear wrong.
Note the surface annotation code is correct: you need to fix this function to be able to create coordinates from outer properly.
I suggest you rename Mabelle's tubemesh function to extrudeSurfaceCoordinates() and have an additional option outward=True (you will supply False, which will internally use -wall thickness, but importantly must keep layer ordering from inside to out and d3 direction from inside to out. This should be a small change to this function; I don't want to see a whole copy of the code for the outward=False case, should just be a different sequence of inserting in the lists, e.g. list.insert(0, layer) for that case, where list.append(layer) is used for outward=True.
Please be careful to rename all variables so they say e.g. xSurf rather than xInner and ensure the function arguments are correctly documented.
Update comment to say 'create inner layers from outer' in bladder.
Please make sure all the tests pass and the annotations look correct. Check Colon etc. look correct and its annotations are correct. Be careful that all previous uses of getCoordinateFromInner call the new function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.