Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply zinc group changes #226

Merged
merged 9 commits into from
Jun 22, 2023
Merged

Apply zinc group changes #226

merged 9 commits into from
Jun 22, 2023

Conversation

rchristie
Copy link
Member

No description provided.

Copy link
Contributor

@mlin865 mlin865 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes read well, just need a change to fix alphabetical order. Note that code has not been tested as it relies on updates in zinc.

from scaffoldmaker.utils.vector import magnitude, setMagnitude, crossproduct3, normalise
from cmlibs.maths.vectorops import add, cross, dot, mult, normalize, sub
from scaffoldmaker.utils.vector import magnitude
from cmlibs.maths.vectorops import cross, dot, mult, normalize, sub
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move lines "from cmlibs..." before "from scaffoldmaker..."

Fix a number of pep8 issues in lung2.
@rchristie rchristie merged commit 8ae8756 into ABI-Software:main Jun 22, 2023
@rchristie rchristie deleted the groups branch June 22, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants