Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decode JSON containing sub-scaffoldPackages #222

Merged
merged 3 commits into from
Apr 20, 2023
Merged

Decode JSON containing sub-scaffoldPackages #222

merged 3 commits into from
Apr 20, 2023

Conversation

Kayvv
Copy link
Contributor

@Kayvv Kayvv commented Apr 19, 2023

No description provided.

hsorby
hsorby approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@hsorby hsorby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, @rchristie for visibility.

rchristie
rchristie approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@rchristie rchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we will have more than one nested Scaffold package in some cases.

@hsorby hsorby merged commit f8b9f7a into ABI-Software:main Apr 20, 2023
@Kayvv Kayvv deleted the decode_JSON branch May 1, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchristie rchristie rchristie approved these changes

@hsorby hsorby hsorby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kayvv @hsorby @rchristie