Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bladder documentation #210

Merged
merged 6 commits into from
Aug 29, 2022
Merged

Bladder documentation #210

merged 6 commits into from
Aug 29, 2022

Conversation

zekh167
Copy link
Contributor

@zekh167 zekh167 commented Aug 28, 2022 •
edited
Loading

Hi Richard. I added the documentation for bladder and added the image as well.

rchristie
rchristie requested changes Aug 28, 2022
View reviewed changes
Copy link
Member

@rchristie rchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some small improvements in comments.

docs/scaffolds/bladder.rst Outdated Show resolved Hide resolved
docs/scaffolds/bladder.rst Outdated Show resolved Hide resolved
docs/scaffolds/bladder.rst Outdated Show resolved Hide resolved
docs/scaffolds/bladder.rst Show resolved Hide resolved
@zekh167
Copy link
Contributor Author

zekh167 commented Aug 29, 2022

Thanks Richard. I applied your comments.

rchristie
rchristie approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@rchristie rchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@rchristie rchristie merged commit 724c482 into ABI-Software:main Aug 29, 2022
@zekh167 zekh167 deleted the bladder_documentation branch August 29, 2022 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchristie rchristie rchristie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zekh167 @rchristie