Lens #21
Lens #21
Conversation
…s and halfaxialThickness are equal
| cls.generateBaseMesh(baseRegion, options) | ||
|
|
||
| meshrefinement = MeshRefinement(baseRegion, region) | ||
| meshrefinement.refineAllElementsCubeStandard3d(refineElementsCountAround, refineElementsCountUp, refineElementsCountRadial) |
| options['Anterior radius of curvature'] = options['Axial thickness']*0.5 | ||
|
|
||
| @classmethod | ||
| def sphereToLens(cls, region, options): |
There was a problem hiding this comment.
Pass actual parameters to this function, not options dict. I.e.. coordinates, radiusSphere, radiusAnt, radiusPos, lensThickness, sphericalRadiusFraction etc. Describe each argument using :param NAME: description.
Can get fieldmodule from coordinates field, so no need to pass:
fm = coordinates.getFieldmodule()
Function and description should state that it defines a field giving positions on a spherical lens as functions of positions in the sphere.
I would make this a standalone function e.g.:
def getSphereToLensCoordinates(args):
| """ | ||
| fm = region.getFieldmodule() | ||
| fm.beginChange() | ||
| cache = fm.createFieldcache() |
|
|
||
| class MeshType_3d_lens1: | ||
| ''' | ||
| classdocs |
There was a problem hiding this comment.
Describe class here. Can be same text as at top of file, but more detailed.
Worth mentioning that it is a spherical lens, and that the lens is created by a function morphing a sphere to the lens.
| def checkOptions(options): | ||
| MeshType_3d_solidsphere1.checkOptions(options) | ||
| for key in [ | ||
| 'Spherical radius fraction', |
There was a problem hiding this comment.
Remove Posterior/Anterior radii from minimum zero as handled below.
I like the check options to be in the order they appear in the dictionary (except where a the same check is applied to several options e.g. if options[key] < 0.0.
I.e. check min 0.0 for 'Axial thickness', 'Spherical radius fraction'. Then min Anterior radius, min Posterior radius. Use 'for key in [anterior/posterior]' as same expression. Lastly limit Spherical radius fraction to max 1.0.
No description provided.