Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3D Human stomach #19

Merged
merged 3 commits into from
Nov 27, 2018
Merged

3D Human stomach #19

merged 3 commits into from
Nov 27, 2018

Conversation

Jagirhussan
Copy link
Contributor

3D Human stomach meshtype has been created and tested.
Request to pull the code (meshtype_3d_human_stomach.py) into the main branch to enable development of web interface.

rchristie
rchristie requested changes Nov 27, 2018
View reviewed changes
Copy link
Member

@rchristie rchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds a dependency on scipy which is acceptable for now.
Eventually wish to replace with a fully generated stomach based on a centreline.
Approve for addition once conflict in scaffoldmaker.py (now called scaffolds.py) is resolved.

rchristie
rchristie reviewed Nov 27, 2018
View reviewed changes
Copy link
Member

@rchristie rchristie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename class to ~stomachhuman1 for consistency. Add in alphabetical order in scaffolds.py.

@rchristie rchristie mentioned this pull request Nov 27, 2018
Merged
@rchristie rchristie merged commit c8f2969 into ABI-Software:master Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchristie rchristie rchristie requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jagirhussan @rchristie