Flat bladder #186
Merged
Flat bladder #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…desAndElements" function.
rchristie
requested changes
Jun 3, 2022
|
@zekh167 - have all the review comments been addressed and this is ready for the next round of review? |
|
@andre, yes, it is ready for next review. However, I'm going to add the flat bladder to the new bladder code as well. |
|
The issues have been fixed and it's ready for final review. |
rchristie
requested changes
Aug 5, 2022
tests/test_colonsegment.py
Outdated
| @@ -117,7 +117,7 @@ def test_mousecolonsegment1(self): | |||
| self.assertAlmostEqual(surfaceArea, 468.17062489996886, delta=1.0E-6) | |||
| result, flatSurfaceArea = flatSurfaceAreaField.evaluateReal(fieldcache, 1) | |||
| self.assertEqual(result, RESULT_OK) | |||
| self.assertAlmostEqual(flatSurfaceArea, surfaceArea, delta=1.0E-3) | |||
| self.assertAlmostEqual(flatSurfaceArea, 468.1706248998369, delta=1.0E-3) | |||
There was a problem hiding this comment.
Revert this line as it should already pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two hemi bladders named as "left hemi-bladder" and "right hemi-bladders" since they include left and right ureters, respectively. However, these are not anatomical terms and only used for fitting purposes for flat prep.