Stomach layers #168
Stomach layers #168
Conversation
There was a problem hiding this comment.
Looks great.
Only one real issue: The Ostium is not working as expect for me (creating it on its own). If I set more than one layer through the wall of the ostium or vessels, it multiplies the wall thickness. Expected behaviour is for the overall thickness to be as specified, but for the relative thicknesses to proportionately distribute layer thicknesses from the overall thickness.
Everything else is mainly questions, some comments in code, plus:
The rat stomach has gaps in the 'mucosa of stomach' between esophagogastric junction and body. Check that is as expected.
| @@ -82,10 +82,11 @@ def test_cecum1(self): | |||
| fieldcache = fieldmodule.createFieldcache() | |||
| result, surfaceArea = surfaceAreaField.evaluateReal(fieldcache, 1) | |||
| self.assertEqual(result, RESULT_OK) | |||
| self.assertAlmostEqual(surfaceArea, 65959.34314511667, delta=1.0E-6) | |||
| self.assertAlmostEqual(surfaceArea, 65960.20655074248, delta=1.0E-6) | |||
There was a problem hiding this comment.
For future reference, I suggest these deltas be made larger e.g. 1.0E-3 here (or barely more than single precision differences of 7-8 sig figs i.e. the value / 1E7 or 1E8); since these are integrals over the mesh errors build up and each OS/compiler will give slightly different results - anticipating the testing being actually run on different systems.
| @@ -74,12 +74,12 @@ def getDefaultOptions(parameterSetName='Default'): | |||
| 'Start tenia coli width derivative': 0.0, | |||
| 'End tenia coli width': 10.0, | |||
| 'End tenia coli width derivative': 0.0, | |||
| 'Tenia coli thickness': 1.6, | |||
| 'Tenia coli thickness': 0.6, | |||
There was a problem hiding this comment.
Can you please check whether these colon parameters are meant to change here?
There was a problem hiding this comment.
Yes the tenia coli thickness has been updated to match the measurements of human colons (recent data from Simon Brookes)
|
I have fixed the issue with ostium and I confirm there is a gap in the mucosa around the esophagus for rat stomach. |
No description provided.