Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add human lung lower lobe #103

Merged
merged 4 commits into from
Nov 24, 2020
Merged

Conversation

arti-sukasem
Copy link
Contributor

No description provided.

lNodeIds[n3][n2][n1] = nodeIdentifier
nodeIdentifier += 1

x = 3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems no need for (x = 3). So, you can remove this line.

nodeIdentifier += 1

# Create elements

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also remove this empty line.


x = 3
# Create element

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this empty line.

Copy link
Member

@rchristie rchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor fix then we'll pull this in -- see comment.
Note I'm still thinking about the 7 node element, but we can fix this later.

src/scaffoldmaker/meshtypes/meshtype_3d_lung1.py Outdated Show resolved Hide resolved
@rchristie rchristie merged commit 90769b3 into ABI-Software:master Nov 24, 2020
@arti-sukasem arti-sukasem deleted the humanlung branch April 13, 2022 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants