Rescale derivatives for annulus mesh #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchristie
requested changes
Nov 18, 2020
Comment on lines
196
to
198
| 'Ostium position around': 0.67, # should be on the dorsal part (> 0.5) | ||
| 'Ostium position down': 0.83, | ||
| 'Number of radial elements on annulus': 2, |
There was a problem hiding this comment.
Would you mind fixing these names...
Key is that all of these options are about the Ureter, which is built with an ostium + annulus. Also, my 'standard' is to always start numbers of elements with 'Number of elements' + qualifiers, and in the code elementsCount~.
Can you please rename these to:
Ureter position around
Ureter position down
Number of elements ureter radial
& in the code update variables they are assigned to appropriately.
| @@ -343,7 +352,7 @@ def generateBaseMesh(cls, region, options): | |||
| ostiumOptions = options['Ureter'] | |||
| ostiumDefaultOptions = ostiumOptions.getScaffoldSettings() | |||
| elementsCountAroundOstium = ostiumDefaultOptions['Number of elements around ostium'] | |||
| elementsCountAnnulusRadially = options['Number of elements radially on annulus'] | |||
| elementsCountAnnulusRadial = options['Number of radial elements on annulus'] | |||
There was a problem hiding this comment.
Rename to elementsCountUreterRadial, as earlier.
Comment on lines
356
to
357
| ostiumPositionAround = options['Ostium position around'] | ||
| ostiumPositionDown = options['Ostium position down'] |
There was a problem hiding this comment.
Renam ureterPosition~, and other variables such as ostium1Position --> ureter1Position.
| trackSurfaceOstium2, ostium2Position, ostiumElementPositionDown, | ||
| ostiumElementPositionAround, xBladder, d1Bladder, d2Bladder, | ||
| nextNodeIdentifier, nextElementIdentifier, elementsCountAnnulusRadially, | ||
| def generateOstiumsAndAnnulusMeshOnBladder(region, nodes, mesh, ostiumDefaultOptions,elementsCountAround, |
Annulus fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.