Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation tool related update #19

Merged
merged 7 commits into from
Jan 6, 2025

Conversation

ddjnw1yu
Copy link
Contributor

@ddjnw1yu ddjnw1yu commented Dec 2, 2024

Some style changes and added the copy feature.

Screenshot 2024-12-02 at 1 06 00 PM Screenshot 2024-12-02 at 1 55 23 PM Screenshot 2024-12-02 at 2 08 45 PM

Copy link
Member

@alan-wu alan-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks pretty good to me and it will be even better if the copy button can be made consistent with how it looks with connectivity when it is on the sidebar as shown in the screenshot -
image

Comment on lines 282 to 297
this.evidence.forEach((evi) => {
let eviObject = {}
if (evi.includes("DOI:")) {
eviObject[evi] = evi.replace("DOI:", "https://doi.org/");
} else if (evi.includes("PMID:")) {
eviObject[evi] = evi.replace(
"PMID:",
"https://pubmed.ncbi.nlm.nih.gov/"
);
evidenceURLs.push(new URL(link));
}
if (evi in eviObject) {
evidenceURLs.push(eviObject);
} else {
evidenceURLs.push(evidence);
evidenceURLs.push(evi);
}
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change here has broken my script as evidenceURLs has been modified to contain mixed type (string / object) and they are pushed onto the server.

Copy link
Member

@alan-wu alan-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@alan-wu alan-wu merged commit 961d275 into ABI-Software:main Jan 6, 2025
@ddjnw1yu ddjnw1yu deleted the annotation-tool-related-update branch January 7, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants