WIP: Rework pod history view #161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smuething
force-pushed
the
rework-pod-history-view
branch
from
82d3e63 to
02f7139
Compare
smuething
changed the base branch from
omnipod_eros_dev
to
omnipod_eros_dev_remove_omnipod_pump_state
This replaces the current Omnipod history view, which is limited to 24 hours of data, with a new version that allows for infinite scrolling. It also highlights pod change events. Currently, it's still missing the event type filtering functionality of the old view.
- Turn main list view into a fragment - Use data binding - Fire event when clicking history entries - Show toast when receiving history entry click event
This is required to be able to pass it to fragments and activities
smuething
force-pushed
the
rework-pod-history-view
branch
from
02f7139 to
1578aa5
Compare
bartsopers
force-pushed
the
omnipod_eros_dev_remove_omnipod_pump_state
branch
from
cac3bc5 to
b1abc55
Compare
bartsopers
changed the base branch from
omnipod_eros_dev_remove_omnipod_pump_state
to
omnipod_eros_dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've started work on improving the pod history view. Initially, I just wanted to be able to see the complete history of the current pod, but then I ended up implementing an infinitely scrollable history.
It's not complete yet, I still need to add: