Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset player snapshot after teleport to avoid deleting join location #332

Merged
merged 5 commits into from
Nov 2, 2022

Conversation

steve4744
Copy link
Contributor

  1. The player data snapshot is being reset before the teleportCourseCompletion() method is called. If the player should be teleported to their join location, this will no longer be recorded in the snapshot data. Fixed by moving the reset to after the teleport.

  2. The %parkour_player_course_position_[course]% placeholder only works if there is a single time recorded in the database for the player on that course. If the player has multiple times the result is fairly random. Fixed by getting the best time rather than the first time.

  3. The %parkour_current_checkpoint_next% code was missing, so this has been added.

  4. The length check for %parkour_player_course_xxxxx% is now fixed.

  5. Updated docs with an example of how to create Parkour holograms using the DecentHolograms plugin.

@A5H73Y A5H73Y merged commit e719aa0 into A5H73Y:master Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants