reset player snapshot after teleport to avoid deleting join location #332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The player data snapshot is being reset before the
teleportCourseCompletion()
method is called. If the player should be teleported to their join location, this will no longer be recorded in the snapshot data. Fixed by moving the reset to after the teleport.The
%parkour_player_course_position_[course]%
placeholder only works if there is a single time recorded in the database for the player on that course. If the player has multiple times the result is fairly random. Fixed by getting the best time rather than the first time.The
%parkour_current_checkpoint_next%
code was missing, so this has been added.The length check for
%parkour_player_course_xxxxx%
is now fixed.Updated docs with an example of how to create Parkour holograms using the
DecentHolograms
plugin.