add events for parkour reset commands #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add a Parkour event for resetting a player, course and leader board. |
A5H73Y
requested changes
May 19, 2022
| @@ -1093,6 +1095,7 @@ public void resetPlayer(CommandSender commandSender, String targetPlayerId) { | |||
| resetPlayer(targetPlayer); | |||
| TranslationUtils.sendValueTranslation("Parkour.Reset", targetPlayerId, commandSender); | |||
| PluginUtils.logToFile(targetPlayerId + " player was reset by " + commandSender.getName()); | |||
| Bukkit.getServer().getPluginManager().callEvent(new ParkourResetPlayerEvent((Player)targetPlayer, null)); | |||
There was a problem hiding this comment.
Instead of casting this as Player, which could potentially cause an issue.
We could instead use targetPlayer.getPlayer() which I believe should be a nullable field.
There was a problem hiding this comment.
That's fine, and is now updated.
| @@ -288,6 +292,7 @@ public void resetPlayerCourseLeaderboards(CommandSender commandSender, String ta | |||
| TranslationUtils.sendValueTranslation("Parkour.Reset", targetPlayerId + "'s " | |||
| + courseName + " Leaderboards", commandSender); | |||
| PluginUtils.logToFile(targetPlayerId + "'s " + courseName + " leaderboards were reset by " + commandSender.getName()); | |||
| Bukkit.getServer().getPluginManager().callEvent(new ParkourResetLeaderboardEvent((Player) targetPlayer, courseName)); | |||
A5H73Y
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.