Update readme #104

lucasgomide · 2015-11-01T11:16:20Z

Add nohup default #101 and add info about resque_dynamic_schedule to README.md

…fore than run some command

…dhanson358

…_env

dmarkow · 2015-11-02T15:35:18Z

Thank you, I'll take a deeper look when I have a little time.

You've effectively removed nohup entirely from the Capistrano V3 codebase (capistrano_integration.rb is the V2 code, where you added the nohup_cmd variable, but the V3 file capistrano-resque.rake has had all nohup code completely removed)
I'd strongly prefer to have separate pull requests for separate additions, whereas this one seems to lump a bunch of stuff together (nohup, dynamic schedule, extra env (which is already in Allow adding of arbitrary environment variables to start script #95), etc.)
There are some indentation issues (see comments on diff)

dmarkow · 2015-11-02T15:35:43Z

lib/capistrano-resque/tasks/capistrano-resque.rake

@@ -130,7 +131,7 @@ namespace :resque do
        create_pid_path
        pid = "#{fetch(:resque_pid_path)}/scheduler.pid"
        within current_path do
-          execute :nohup, %{#{SSHKit.config.command_map[:rake]} RACK_ENV=#{rails_env} RAILS_ENV=#{rails_env} PIDFILE=#{pid} BACKGROUND=yes #{"VERBOSE=1 " if fetch(:resque_verbose)}MUTE=1 #{"DYNAMIC_SCHEDULE=yes " if fetch(:resque_dynamic_schedule)}#{"environment " if fetch(:resque_environment_task)}resque:scheduler #{output_redirection}}
+           execute %{cd #{release_path} && #{SSHKit.config.command_map[:rake]} #{fetch(:resque_extra_env)} RACK_ENV=#{rails_env} RAILS_ENV=#{rails_env} PIDFILE=#{pid} BACKGROUND=yes #{"VERBOSE=1 " if fetch(:resque_verbose)}MUTE=1 #{"DYNAMIC_SCHEDULE=yes " if fetch(:resque_dynamic_schedule)}#{"environment " if fetch(:resque_environment_task)}resque:scheduler #{output_redirection}}


Please fix indentation

lucasgomide · 2015-11-03T09:30:58Z

Yeah, of course.

I'll create others pull requests from this, ok ? it's better

lucasgomide added 5 commits October 31, 2015 17:22

Make "nohup" non-default optional to addres and go to release path be…

04818aa

…fore than run some command

Allow adding of arbitrary environment variables to start script from …

9b3da16

…dhanson358

Update readme and changes env variable name extra_env to resque_extra…

864b87a

…_env

Using extra_env for start resque:scheduler too

ba35177

Add info about DYNAMIC_SCHEDULE to README.md

6f5bc75

dmarkow reviewed Nov 2, 2015
View reviewed changes

lucasgomide closed this Nov 3, 2015

lucasgomide deleted the update-readme branch November 3, 2015 09:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update readme #104

Update readme #104

lucasgomide commented Nov 1, 2015

dmarkow commented Nov 2, 2015

dmarkow Nov 2, 2015

lucasgomide commented Nov 3, 2015

Update readme #104

Update readme #104

Conversation

lucasgomide commented Nov 1, 2015

dmarkow commented Nov 2, 2015

dmarkow Nov 2, 2015

Choose a reason for hiding this comment

lucasgomide commented Nov 3, 2015