-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Revert "Add github action for publishing releases"" #46
Conversation
This reverts commit e3efd97.
This comment was marked as resolved.
This comment was marked as resolved.
@9p4 I've addressed the versioning comments, and pinned a ref to a commit, rather than the head of a main branch. |
@9p4 @crobibero @Pfuenzle if any of yall feel up to reviewing this, please have at it! Once this is merged, I will create some formal releases from the existing tags on github and the publish system should be set to transition over to being automated by the CI |
Oh, @9p4 looks like you've configured a whitelist of actions - https://github.com/9p4/jellyfin-plugin-sso/actions/runs/2525642835
I'll give a review: Doesn't use token:
Uses token but I trust it at the pinned version: |
So specifically, pls whitelist:
|
Should be good |
I don't think the ref for kevinjil/plugin action matches EDIT - nvm, I just changed the pinned ref from a tag to the commit hash |
This reverts commit e3efd97.
From PR #39