Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Add github action for publishing releases"" #46

Merged
merged 3 commits into from
Jun 19, 2022

Conversation

strazto
Copy link
Collaborator

@strazto strazto commented Jun 18, 2022

This reverts commit e3efd97.

From PR #39

@strazto strazto marked this pull request as draft June 18, 2022 13:05
@strazto

This comment was marked as resolved.

@strazto strazto marked this pull request as ready for review June 18, 2022 13:14
@strazto
Copy link
Collaborator Author

strazto commented Jun 18, 2022

@9p4 I've addressed the versioning comments, and pinned a ref to a commit, rather than the head of a main branch.
It should be sufficient to mitigate your concern about supply chain attacks - The current state of these actions is not malicious, and we can count on them remaining that way.

@strazto strazto requested a review from 9p4 June 18, 2022 13:23
@strazto
Copy link
Collaborator Author

strazto commented Jun 18, 2022

@9p4 @crobibero @Pfuenzle if any of yall feel up to reviewing this, please have at it!

Once this is merged, I will create some formal releases from the existing tags on github and the publish system should be set to transition over to being automated by the CI

@strazto strazto merged commit 6a0fcfe into 9p4:main Jun 19, 2022
@strazto
Copy link
Collaborator Author

strazto commented Jun 19, 2022

Oh, @9p4 looks like you've configured a whitelist of actions -

https://github.com/9p4/jellyfin-plugin-sso/actions/runs/2525642835

fjogeleit/[email protected], oddstr13/jellyfin-plugin-repository-manager@master, softprops/action-gh-release@50195ba, and kevinjil/[email protected] are not allowed to be used in 9p4/jellyfin-plugin-sso. Actions in this workflow must be: within a repository owned by 9p4, created by GitHub, verified in the GitHub Marketplace, or matching the following: creyd/[email protected].

I'll give a review:

Doesn't use token:

  • fjogeleit/[email protected],
  • oddstr13/jellyfin-plugin-repository-manager@master,
    • I do notice that I somehow forgot to pin this

Uses token but I trust it at the pinned version:

@strazto strazto deleted the update-ci branch June 19, 2022 23:22
@strazto strazto mentioned this pull request Jun 29, 2022
@strazto
Copy link
Collaborator Author

strazto commented Jun 30, 2022

So specifically, pls whitelist:

fjogeleit/[email protected],oddstr13/jellyfin-plugin-repository-manager@b9e92867a6aa279d611a5ea80cf61f6358838c39,softprops/action-gh-release@50195ba7f6f93d1ac97ba8332a178e008ad176aa,kevinjil/[email protected]

@9p4
Copy link
Owner

9p4 commented Jun 30, 2022

Should be good

@strazto
Copy link
Collaborator Author

strazto commented Jun 30, 2022

I don't think the ref for kevinjil/plugin action matches
The config I gave in the above code block should work

EDIT - nvm, I just changed the pinned ref from a tag to the commit hash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants