Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version in SSO-Auth.csproj #169

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Update version in SSO-Auth.csproj #169

merged 1 commit into from
Feb 23, 2024

Conversation

lf-
Copy link
Contributor

@lf- lf- commented Feb 23, 2024

This is what is appearing in the Jellyfin UI when I put (a symlink to my own build of, but with the ~same meta.json) jellyfin-plugin-sso at /var/lib/jellyfin/plugins/sso. It seems to be due to the assembly version not matching the actual version of the software. But I am wondering if it's actually just Jellyfin ignoring my meta.json :P

image

@9p4
Copy link
Owner

9p4 commented Feb 23, 2024

Out of curiosity, what repository are you using for the plugin?

@lf-
Copy link
Contributor Author

lf- commented Feb 23, 2024

Yours; I just do my own packaging from source: https://github.com/lf-/dotfiles/blob/75439240b962bea400fb8b9eda9cbf095baa0b7c/configs/nix/packages/jellyfin-plugin-sso/package.nix. This builds a directory like this:

configs/nix » ls result                                                                                                                                                              main
IdentityModel.dll  IdentityModel.OidcClient.dll  meta.json  SSO-Auth.dll  SSO-Auth.pdb

I then symlink that directory with systemd-tmpfiles to /var/lib/jellyfin/plugins/sso.

Here's a log of startup. Interestingly it actually respects meta.json in the log here, but not in the UI. Weird:

Feb 23 01:06:40 cube jellyfin[888625]: [01:06:40] [INF] [1] Main: Jellyfin version: 10.8.13
Feb 23 01:06:40 cube jellyfin[888625]: [01:06:40] [INF] [1] Main: Environment Variables: ["[DOTNET_ROOT, /nix/store/8w2jxdypyzgjyzqgckiikwnnxmyiysz7-aspnetcore-runtime-6.0.26]", "[JELLYF
IN_LOG_DIR, /var/lib/jellyfin/log]"]
Feb 23 01:06:40 cube jellyfin[888625]: [01:06:40] [INF] [1] Main: Arguments: ["/nix/store/1j432w8zig3x87vmnaqx13m8s0bsfj3s-jellyfin-10.8.13/lib/jellyfin/jellyfin.dll", "--ffmpeg", "/nix/
store/8x1kg47xg9rzsml6hx3iga914aj1h2nz-jellyfin-ffmpeg-6.0.1-2-bin/bin/ffmpeg", "--webdir", "/nix/store/nyy5mg14ywv6jh54ssczhq5h2whq3lkq-jellyfin-web-10.8.13/share/jellyfin-web", "--data
dir", "/var/lib/jellyfin", "--configdir", "/var/lib/jellyfin/config", "--cachedir", "/var/cache/jellyfin", "--logdir", "/var/lib/jellyfin/log"]
Feb 23 01:06:40 cube jellyfin[888625]: [01:06:40] [INF] [1] Main: Operating system: Linux
Feb 23 01:06:40 cube jellyfin[888625]: [01:06:40] [INF] [1] Main: Architecture: X64
Feb 23 01:06:40 cube jellyfin[888625]: [01:06:40] [INF] [1] Main: 64-Bit Process: True
Feb 23 01:06:40 cube jellyfin[888625]: [01:06:40] [INF] [1] Main: User Interactive: True
Feb 23 01:06:40 cube jellyfin[888625]: [01:06:40] [INF] [1] Main: Processor count: 4
Feb 23 01:06:40 cube jellyfin[888625]: [01:06:40] [INF] [1] Main: Program data path: /var/lib/jellyfin
Feb 23 01:06:40 cube jellyfin[888625]: [01:06:40] [INF] [1] Main: Web resources path: /nix/store/nyy5mg14ywv6jh54ssczhq5h2whq3lkq-jellyfin-web-10.8.13/share/jellyfin-web
Feb 23 01:06:40 cube jellyfin[888625]: [01:06:40] [INF] [1] Main: Application directory: /nix/store/1j432w8zig3x87vmnaqx13m8s0bsfj3s-jellyfin-10.8.13/lib/jellyfin/
Feb 23 01:06:41 cube jellyfin[888625]: [01:06:41] [INF] [1] Emby.Server.Implementations.AppBase.BaseConfigurationManager: Setting cache path: /var/cache/jellyfin
Feb 23 01:06:41 cube jellyfin[888625]: [01:06:41] [INF] [1] Emby.Server.Implementations.ApplicationHost: Loading assemblies
Feb 23 01:06:41 cube jellyfin[888625]: [01:06:41] [INF] [1] Emby.Server.Implementations.Plugins.PluginManager: Loaded assembly IdentityModel.OidcClient, Version=5.0.0.0, Culture=neutral,
 PublicKeyToken=5580d04c1b6c37c1 from /var/lib/jellyfin/plugins/sso/IdentityModel.OidcClient.dll
Feb 23 01:06:41 cube jellyfin[888625]: [01:06:41] [INF] [1] Emby.Server.Implementations.Plugins.PluginManager: Loaded assembly IdentityModel, Version=5.2.0.0, Culture=neutral, PublicKeyT
oken=e7877f4675df049f from /var/lib/jellyfin/plugins/sso/IdentityModel.dll
Feb 23 01:06:41 cube jellyfin[888625]: [01:06:41] [INF] [1] Emby.Server.Implementations.Plugins.PluginManager: Loaded assembly SSO-Auth, Version=3.3.0.0, Culture=neutral, PublicKeyToken=
null from /var/lib/jellyfin/plugins/sso/SSO-Auth.dll
Feb 23 01:06:41 cube jellyfin[888625]: [01:06:41] [INF] [1] Jellyfin.Networking.Manager.NetworkManager: Defined LAN addresses : [10.0.0.0/8,172.16.0.0/12,192.168.0.0/16]
Feb 23 01:06:41 cube jellyfin[888625]: [01:06:41] [INF] [1] Jellyfin.Networking.Manager.NetworkManager: Defined LAN exclusions : []
Feb 23 01:06:41 cube jellyfin[888625]: [01:06:41] [INF] [1] Jellyfin.Networking.Manager.NetworkManager: Using LAN addresses: [10.0.0.0/8,172.16.0.0/12,192.168.0.0/16]
Feb 23 01:06:41 cube jellyfin[888625]: [01:06:41] [INF] [1] Jellyfin.Networking.Manager.NetworkManager: Using bind addresses: []
Feb 23 01:06:41 cube jellyfin[888625]: [01:06:41] [INF] [1] Jellyfin.Networking.Manager.NetworkManager: Using bind exclusions: []
Feb 23 01:06:43 cube jellyfin[888625]: [01:06:43] [INF] [1] Emby.Server.Implementations.Plugins.PluginManager: Loaded plugin: SSO Authentication 3.5.2.3
Feb 23 01:06:43 cube jellyfin[888625]: [01:06:43] [INF] [1] Emby.Server.Implementations.Plugins.PluginManager: Loaded plugin: TMDb 10.8.13.0
Feb 23 01:06:43 cube jellyfin[888625]: [01:06:43] [INF] [1] Emby.Server.Implementations.Plugins.PluginManager: Loaded plugin: Studio Images 10.8.13.0
Feb 23 01:06:43 cube jellyfin[888625]: [01:06:43] [INF] [1] Emby.Server.Implementations.Plugins.PluginManager: Loaded plugin: OMDb 10.8.13.0
Feb 23 01:06:43 cube jellyfin[888625]: [01:06:43] [INF] [1] Emby.Server.Implementations.Plugins.PluginManager: Loaded plugin: MusicBrainz 10.8.13.0
Feb 23 01:06:43 cube jellyfin[888625]: [01:06:43] [INF] [1] Emby.Server.Implementations.Plugins.PluginManager: Loaded plugin: AudioDB 10.8.13.0
Feb 23 01:06:43 cube jellyfin[888625]: [01:06:43] [INF] [1] Main: Kestrel listening on Any IP4 Address

@9p4
Copy link
Owner

9p4 commented Feb 23, 2024

I use https://github.com/oddstr13/jellyfin-plugin-repository-manager to manage the packages and releases, so that may be why I haven't noticed this issue.

@9p4 9p4 merged commit 29189a9 into 9p4:main Feb 23, 2024
1 of 2 checks passed
@lf-
Copy link
Contributor Author

lf- commented Feb 23, 2024

I use https://github.com/oddstr13/jellyfin-plugin-repository-manager to manage the packages and releases, so that may be why I haven't noticed this issue.

Oh, shoot. I was reading the code while implementing my packaging, I think -p:Version=blah is what actually sets that. ah no they do sed crimes. I can just do that too.

@lf-
Copy link
Contributor Author

lf- commented Feb 23, 2024

Oh actually, their solution is way more crimes than are at all necessary! You can just set it with -p:AssemblyVersion=${version} -p:FileVersion=${version} in the dotnet build flags!

Thanks for questioning what I was doing, it was in fact my bug that this didn't match the official build, but simultaneously a bit of weird fragility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants