-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version in SSO-Auth.csproj #169
Conversation
Out of curiosity, what repository are you using for the plugin? |
Yours; I just do my own packaging from source: https://github.com/lf-/dotfiles/blob/75439240b962bea400fb8b9eda9cbf095baa0b7c/configs/nix/packages/jellyfin-plugin-sso/package.nix. This builds a directory like this:
I then symlink that directory with systemd-tmpfiles to Here's a log of startup. Interestingly it actually respects meta.json in the log here, but not in the UI. Weird:
|
I use https://github.com/oddstr13/jellyfin-plugin-repository-manager to manage the packages and releases, so that may be why I haven't noticed this issue. |
Oh, shoot. I was reading the code while implementing my packaging, |
Oh actually, their solution is way more crimes than are at all necessary! You can just set it with Thanks for questioning what I was doing, it was in fact my bug that this didn't match the official build, but simultaneously a bit of weird fragility. |
This is what is appearing in the Jellyfin UI when I put (a symlink to my own build of, but with the ~same meta.json) jellyfin-plugin-sso at
/var/lib/jellyfin/plugins/sso
. It seems to be due to the assembly version not matching the actual version of the software. But I am wondering if it's actually just Jellyfin ignoring my meta.json :P