Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#47 - Fix error: missing GetMetadata method #48

Merged
merged 3 commits into from
Jun 20, 2019
Merged

#47 - Fix error: missing GetMetadata method #48

merged 3 commits into from
Jun 20, 2019

Conversation

dpetzold
Copy link
Contributor

Fixes error:

../../../../1.12.5/src/github.com/99designs/keyring/pass.go:34:3: cannot
use pass (type *passKeyring) as type Keyring in return argument:
        *passKeyring does not implement Keyring (missing GetMetadata method)

This will get it to compile. I'm sure it should do more though.

../../../../1.12.5/src/github.com/99designs/keyring/pass.go:34:3: cannot
use pass (type *passKeyring) as type Keyring in return argument:
        *passKeyring does not implement Keyring (missing GetMetadata method)
@lox
Copy link
Collaborator

lox commented Jun 18, 2019

Thanks! Good temporary solution at any rate.

@lox
Copy link
Collaborator

lox commented Jun 18, 2019

Will merge as soon as it passes.

@lox
Copy link
Collaborator

lox commented Jun 19, 2019

pass_test.go:54: exec: "pass": executable file not found in $PATH

I wonder how that ever worked.

Should fix error:

```
Error: Your Homebrew is outdated. Please run `brew update`.
Error: Kernel.exit
```
@dpetzold
Copy link
Contributor Author

dpetzold commented Jun 19, 2019

@lox needed to call update homebrew. It should be good to go now :).

@mtibben mtibben merged commit 372329b into 99designs:master Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants