Date is not a mandatory header #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> 2.3. Signature String Construction > > In order to generate the string that is signed with a key, the client > MUST use the values of each HTTP header field in the `headers` > Signature parameter, in the order they appear in the `headers` > Signature parameter. It is out of scope for this document to dictate > what header fields an application will want to enforce, but > implementers SHOULD at minimum include the request target and Date > header fields. https://tools.ietf.org/html/draft-cavage-http-signatures
|
There is a failing test on this build, see https://travis-ci.org/99designs/httpsignatures-go/jobs/222067374 Sadly our org policy breaks the travis hooks that updating the build status in PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to IETF specs
Dateis suggested but not mandatory:https://tools.ietf.org/html/draft-cavage-http-signatures