feat: add logger for use with tracing middleware #3509
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3506, it was discussed to allow users to bring a custom logger to print out the various error logs that might happen during the tracing process to allow users to properly set the right structured logging consistently across the application.
This adds a new
Logger
attribute on theTracer
struct that can take in a Logger that abides by the standardlog
library standard (that is it has at a minimum has the Print/ln/f functions).Defaults to a no-op logger.
I have: