STS AssumeRole Session Tags implementation #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtibben
reviewed
Nov 11, 2020
vault/config.go
Outdated
| if transitiveSessionTags := psection.TransitiveSessionTags; transitiveSessionTags != "" && len(config.TransitiveSessionTags) == 0 { | ||
| for _, tag := range strings.Split(transitiveSessionTags, ",") { | ||
| config.TransitiveSessionTags = append(config.TransitiveSessionTags, strings.TrimSpace(tag)) | ||
| } |
There was a problem hiding this comment.
could you split this logic out into it's own function?
There was a problem hiding this comment.
please check the latest change, I created a couple of setters for vault.Config that parse string into the corresponding map and slice.
I'm not 100% confident that it's the best approach - it's "economical", but kind of moves parsing away from vault.ProfileSection to vault.Config. Please tell me your thoughts on that.
mtibben
reviewed
Nov 11, 2020
| profile.TransitiveSessionTags = append(profile.TransitiveSessionTags, strings.TrimSpace(tag)) | ||
| } | ||
| log.Printf("Using transitive_session_tags %v from AWS_TRANSITIVE_TAGS", profile.TransitiveSessionTags) | ||
| } |
There was a problem hiding this comment.
probably shares some logic with this?
… tags; Added tests for the functions
stanvit
force-pushed
the
session-tags
branch
from
c2dea8e to
a3e7912
Compare
|
@stanvit Thanks a lot for the PR, this is definitely needed, looking forward to seeing this merged 🎉 |
|
@mtibben : anything required to get this PR merged -- I am happy to chip in with any updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is trying to resolve #684 and implements the way to set Session Tags and Transitive Session Tags when
AssumeRole()provider is used.session_tagsandtransitive_session_tagsAWS_SESSION_TAGSandAWS_TRANSITIVE_TAGSIt is possible to configure each profile in the chain individually, as well as the target profile with environment variables.