Handle additional username formats #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all AWS User ARNs have the username as the second field. Some may have it as the 3rd or 4th field. However, it seems very likely that most accounts have them as the last field in the ARN. This patch changes the behavior to grab the last field in the username and I hope that it is behavior preserving for the original use case as well. This patch is required for the organization that I work in and it would be great if we can get this merged upstream!
|
Thanks @cirego |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all AWS User ARNs have the username as the second field. Some may
have it as the 3rd or 4th field. However, it seems very likely that most accounts
have them as the last field in the ARN.
This patch changes the behavior to grab the last field in the username and I hope
that it is behavior preserving for the original use case as well.
This patch is required for the organization that I work in and it would be great if we
can get this merged upstream!
Thanks for all the hard work that went into aws-vault. It's a great tool and I use
it everyday!