-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a basic file backend #63
Conversation
I started working on my own simple file backend before I saw this :-). I think your commit should be rather easy to extend further to use gpg, in the future I mean. Anyway, I tested locally and this works for me. It might be nice to add some tests for non-happy paths. Any plans on whether you'll merge this? |
👍 |
return &fileKeyring{ | ||
PasswordFunc: terminalPrompt, | ||
}, nil | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be better to keep use of the supportedBackends
in keyring.go
to keep the scope small
Why JWT? Does the encryption layer not provide authentication? |
Oh right, it's encrypting the data using the Javascript Object Signing and Encryption (JOSE) and/or JWE (JSON Web Encryption) things that are related to JWT. |
Seems good 👍
Sounds dangerously out of scope. |
This adds a file backend for storing keyring items encrypted in ~/.awsvault/keys/{keyname}. Keys are encrypted as JWT tokens.
The usecase for this is for command-line linux usage. It also opens up the possibility of using it on servers to store credentials.