Add support for the kwallet keyring #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice one @vektah, Godeps need updating. |
|
Mind rebasing master and updating Godeps? |
|
So just to clarify, Kwallet doesn't have libsecret support? That would be the vastly better option IMO: |
vektah
force-pushed
the
add-kwallet-support
branch
from
101a1e2 to
f2e2a99
Compare
vektah
force-pushed
the
add-kwallet-support
branch
from
f2e2a99 to
a9d6bdf
Compare
|
I've rebased and added godeps. The gitignore for vendor threw me off. https://github.com/tmc/keyring/blob/master/keyring_linux.go uses the libsecret dbus api via |
lox
added a commit
that referenced
this pull request
Oct 5, 2015
Add support for the kwallet keyring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the KDE wallet. CLI/Gnome would require their own backends.
When first creating the wallet it will prompt for a new password:
If the wallet is not open it will prompt for the password:
Unlike the OSX keyring the KDE wallet 'entries' are purely key value stores. To fit the entire Item I added a second layer of json encoding.
I'm not sure of the best way to automatically test this. I guess I could stub the dbus connection or the wrapper?
see #23