Handle [sso-session] section #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
dima-vm
force-pushed
the
dl/sso-session
branch
from
2c18da7 to
204fe62
Compare
dima-vm
commented
Dec 9, 2022
vault/config.go
Outdated
| func (s ProfileSection) IsEmpty() bool { | ||
| s.Name = "" | ||
| return s == ProfileSection{} | ||
| } | ||
|
|
||
| // ProfileSections returns all the profile sections in the config | ||
| func (c *ConfigFile) ProfileSections() []ProfileSection { | ||
| result := []ProfileSection{} | ||
| var result []ProfileSection |
There was a problem hiding this comment.
Fixed IDE warning, no semantic change.
| @@ -218,7 +218,7 @@ func (t *tempCredsCreator) provider(config *Config) (aws.CredentialsProvider, er | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| } else if config.HasSSOStartURL() { | |||
| } else if config.HasSSOStartURL() || config.HasSSOSession() { | |||
| return NewSSORoleCredentialsProvider(t.keyring.Keyring, config) | |||
There was a problem hiding this comment.
In proper case, both of them are true. However, [sso-session] may lack sso_start_url. In that case I feel like it should still go the SSO way.
dima-vm
force-pushed
the
dl/sso-session
branch
from
50161f3 to
a92c6b6
Compare
mtibben
reviewed
Dec 18, 2022
.gitignore
Outdated
| @@ -1,3 +1,5 @@ | |||
| /aws-vault | |||
| /aws-vault-* | |||
| /SHA256SUMS | |||
|
|
|||
| /.idea | |||
There was a problem hiding this comment.
put this in your global gitignore
mtibben
reviewed
Dec 18, 2022
| SSORegion string | ||
|
|
||
| // SSORegistrationScopes specifies registration scopes for the AWS IAM Identity Center user portal. | ||
| SSORegistrationScopes string | ||
|
|
There was a problem hiding this comment.
doesn't seem this is ever used?
mtibben
force-pushed
the
dl/sso-session
branch
from
a92c6b6 to
e5ee07e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New AWS CLI changed config format for SSO values. Instead of specifying
sso_start_urlandsso_region,it now makes
sso_sessionprofile param, that points to a separate[sso-session]section.This PR adds support for the
sso_sessionparam and parsing[sso-session]section.