Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: connector #316

Merged
merged 7 commits into from
Jun 25, 2024
Merged

feat: connector #316

merged 7 commits into from
Jun 25, 2024

Conversation

giangndm
Copy link
Contributor

@giangndm giangndm commented Jun 24, 2024

Pull Request

Description

This PR implements Connector service, which enabled some additional features like:

  • logging
  • recording (will be implemented in separate PR)

Checklist

  • I have tested the changes locally.
  • I have reviewed the code changes.
  • I have updated the documentation, if necessary.
  • I have added appropriate tests, if applicable.

Screenshots

If applicable, add screenshots to help explain the changes made.

Additional Notes

Add any additional notes or context about the pull request here.

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 33.05583% with 1367 lines in your changes missing coverage. Please review.

Project coverage is 44.11%. Comparing base (e892eb5) to head (423cde8).

Files Patch % Lines
...ackages/protocol/src/protobuf/cluster_connector.rs 0.00% 196 Missing ⚠️
packages/media_connector/src/sql_storage.rs 64.14% 194 Missing ⚠️
bin/src/http/api_console/connector.rs 0.00% 156 Missing ⚠️
packages/media_connector/src/agent_service.rs 0.00% 106 Missing ⚠️
bin/src/server/gateway/local_rpc_handler.rs 0.00% 92 Missing ⚠️
packages/media_connector/src/handler_service.rs 0.00% 92 Missing ⚠️
bin/src/server/connector.rs 0.00% 89 Missing ⚠️
bin/src/server/connector/remote_rpc_handler.rs 0.00% 86 Missing ⚠️
bin/src/server/gateway/remote_rpc_handler.rs 0.00% 79 Missing ⚠️
packages/media_core/src/endpoint/internal.rs 74.34% 39 Missing ⚠️
... and 27 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #316      +/-   ##
==========================================
- Coverage   45.75%   44.11%   -1.64%     
==========================================
  Files         101      116      +15     
  Lines       10994    12918    +1924     
==========================================
+ Hits         5030     5699     +669     
- Misses       5964     7219    +1255     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giangndm giangndm marked this pull request as ready for review June 25, 2024 17:44
@giangndm giangndm merged commit ec28ecf into 8xFF:master Jun 25, 2024
8 of 10 checks passed
@github-actions github-actions bot mentioned this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant