Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: api gateway and session token for securing cluster #292

Merged
merged 13 commits into from
May 28, 2024

Conversation

giangndm
Copy link
Contributor

@giangndm giangndm commented May 26, 2024

Pull Request

Description

This PR implements API Gateway and Token generator for securing cluster.
The token is a JWT which generated from cluster secure key.

Related Issue

No

Checklist

  • I have tested the changes locally.
  • I have reviewed the code changes.
  • I have updated the documentation, if necessary.
  • I have added appropriate tests, if applicable.

Screenshots

If applicable, add screenshots to help explain the changes made.

Additional Notes

Add any additional notes or context about the pull request here.

@giangndm giangndm changed the title Feat api gateway token secure feat api gateway token secure May 26, 2024
@giangndm giangndm changed the title feat api gateway token secure feat: api gateway and session token for securing cluster May 26, 2024
Copy link

codecov bot commented May 26, 2024

Codecov Report

Attention: Patch coverage is 4.05961% with 1867 lines in your changes are missing coverage. Please review.

Project coverage is 38.10%. Comparing base (6c4fd58) to head (1934846).

Files Patch % Lines
packages/protocol/src/protobuf/cluster_gateway.rs 0.00% 300 Missing ⚠️
bin/src/server/gateway.rs 0.00% 295 Missing ⚠️
packages/media_gateway/src/store/service.rs 0.00% 131 Missing ⚠️
packages/media_gateway/src/store_service.rs 0.00% 119 Missing ⚠️
bin/src/server/media/rpc_handler.rs 0.00% 103 Missing ⚠️
packages/protocol/src/rpc/quinn.rs 0.00% 82 Missing ⚠️
packages/media_gateway/src/store.rs 0.00% 73 Missing ⚠️
packages/media_gateway/src/agent_service.rs 0.00% 71 Missing ⚠️
bin/src/quinn/vsocket.rs 0.00% 70 Missing ⚠️
bin/src/quinn/builder.rs 0.00% 64 Missing ⚠️
... and 27 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #292      +/-   ##
==========================================
- Coverage   46.70%   38.10%   -8.60%     
==========================================
  Files          63       84      +21     
  Lines        7012     8828    +1816     
==========================================
+ Hits         3275     3364      +89     
- Misses       3737     5464    +1727     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giangndm giangndm marked this pull request as ready for review May 28, 2024 03:21
@giangndm giangndm merged commit 5e666d2 into 8xFF:master May 28, 2024
7 of 10 checks passed
@github-actions github-actions bot mentioned this pull request May 28, 2024
@giangndm giangndm deleted the feat-api-gateway-token-secure branch June 6, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant