Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(atoms): add blur content for modals #29

Merged
merged 1 commit into from
Jul 17, 2018
Merged

feat(atoms): add blur content for modals #29

merged 1 commit into from
Jul 17, 2018

Conversation

zouxuoz
Copy link
Contributor

@zouxuoz zouxuoz commented Jul 16, 2018

No description provided.

ej9x
ej9x reviewed Jul 16, 2018
View reviewed changes
src/atoms/Modal/Modal.js Outdated
@@ -16,6 +16,8 @@ type ModalState = {
blurred: boolean,
};

const MODAL_BODY_CLASS = 'modal-shown';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are the styles of this class?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ej9x are you think we should hardcode styles with .modal-shown > #page selector?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zouxuoz I mean about adding blur css styles to the boost.

vorobeez
vorobeez suggested changes Jul 16, 2018
View reviewed changes
src/atoms/Modal/Modal.js Outdated
}
}

updateBodyClass() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think upadteBodyClass is meaningless function name. Can you add more specificity for this method?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vorobeez fixed

@zouxuoz zouxuoz force-pushed the master branch 3 times, most recently from d59aaeb to 810638e Compare July 17, 2018 09:25
@zouxuoz zouxuoz changed the title feat(atoms): add body class when one or more modals is opened feat(atoms): add blur content for modals Jul 17, 2018
@vorobeez vorobeez merged commit d6b6c26 into master Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ej9x ej9x ej9x left review comments

@vorobeez vorobeez vorobeez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zouxuoz @vorobeez @ej9x