fix(Dialog): fix broken close action

8base · Sep 20, 2019 · dc649e2 · dc649e2
1 parent 43a143b
commit dc649e2
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 3 deletions.
diff --git a/...s__/__image_snapshots__/dialog-test-js-components-dialog-with-scroll-1-snap.png b/...s__/__image_snapshots__/dialog-test-js-components-dialog-with-scroll-1-snap.png
diff --git a/...__/__image_snapshots__/dialog-test-js-components-dialog-with-stretch-1-snap.png b/...__/__image_snapshots__/dialog-test-js-components-dialog-with-stretch-1-snap.png
diff --git a/...tests__/__image_snapshots__/logs-test-js-components-logs-with-dialog-1-snap.png b/...tests__/__image_snapshots__/logs-test-js-components-logs-with-dialog-1-snap.png
diff --git a/...ests__/__image_snapshots__/logs-test-js-components-logs-with-stretch-1-snap.png b/...ests__/__image_snapshots__/logs-test-js-components-logs-with-stretch-1-snap.png
diff --git a/src/components/Dialog/Dialog.theme.js b/src/components/Dialog/Dialog.theme.js
@@ -34,8 +34,7 @@ const [DialogTag, themeDialog] = createThemeTag('dialog', {
     display: 'flex',
     flexDirection: 'column',
     justifyContent: 'center',
-    maxHeight: '90%',
-    flex: '0 1 90%',
+    margin: '40px 0',
   },
   modifiers: {
     stretch: {

diff --git a/src/components/Modal/Modal.js b/src/components/Modal/Modal.js
@@ -82,7 +82,7 @@ class Modal extends PureComponent<ModalProps, ModalState> {
             <ModalTag
               modifiers={ rest }
               tagName="div"
-              onMouseDown={ this.onModalMouseDown }
+              onMouseDown={ this.onOverlayMouseDown }
             >
               { typeof children === 'function' ? children(rest) : children }
             </ModalTag>