Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] 86Box Manager allows for folders to be created/named with spaces #127

Open
10x7 opened this issue Jun 26, 2024 · 2 comments
Open

[BUG] 86Box Manager allows for folders to be created/named with spaces #127

10x7 opened this issue Jun 26, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@10x7
Copy link

10x7 commented Jun 26, 2024

(PLEASE DO THIS INSIDE A SAFE ENVIROMENT IF TO REPRODUCE)
If its too late please try the steps I provided to fix it

Describe the bug
86Box Manager allow for user to create/name a folder with spaces included

To reproduce this bug

  • open 86Box Manager
  • (click add or) Add a virtual machine
  • name (the virtual machine) it (ex: hello or this has spaces )
  • after the virtual machine is created select the virtual machine and click configure
  • open any file explorer, go to where the virtual machine is located
  • try and remove the folder

Environment:

  • Host OS: Windows 10 Pro (10.0.19045 Build 19045)
  • 86Box Manager Version 1.7.4

Note:
I'm new to github, If you think this report has an error or i did feel free to correct me

To fix the folder issue:
If you already tried reproducing the bug and can't get rid of the ghost folder you could use 7-Zip and remove the space character (by renaming it) and then deleting it

Screenshots:
start_nom10x7
configure_nom10x7

Even renaming/deleting it results in error (nor chkdisk recgonize this folder)

error_nom10x7
attributes_nom10x7

@10x7 10x7 added the bug Something isn't working label Jun 26, 2024
@daviunic
Copy link
Contributor

Can confirm, trailing spaces aren't trimmed from the name, resulting in Windows acting up with such a folder.

daviunic added a commit that referenced this issue Jun 27, 2024
Fixes issue #127
Also updated copyright year to 2024
@daviunic
Copy link
Contributor

Fixed in the latest commit, will be part of 1.7.5 soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants