Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry functionality to delete firewall settings #35

Merged
merged 2 commits into from
May 11, 2023
Merged

Add retry functionality to delete firewall settings #35

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77a8481
Update name Reply->Retry
tbroden84 May 10, 2023
7690f55
Add retry functionality to delete firewall settings.
tbroden84 May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 44 additions & 17 deletions api/security_firewall.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ func (api *API) waitUntilFirewallConfigured(instanceID, attempt, sleep, timeout

func (api *API) CreateFirewallSettings(instanceID int, params []map[string]interface{}, sleep,
timeout int) ([]map[string]interface{}, error) {
attempt, err := api.createFirewallSettingsWithReply(instanceID, params, 1, sleep, timeout)
attempt, err := api.createFirewallSettingsWithRetry(instanceID, params, 1, sleep, timeout)
if err != nil {
return nil, err
}
Expand All @@ -50,7 +50,7 @@ func (api *API) CreateFirewallSettings(instanceID int, params []map[string]inter
return api.ReadFirewallSettings(instanceID)
}

func (api *API) createFirewallSettingsWithReply(instanceID int, params []map[string]interface{},
func (api *API) createFirewallSettingsWithRetry(instanceID int, params []map[string]interface{},
attempt, sleep, timeout int) (int, error) {
var (
failed map[string]interface{}
Expand All @@ -77,7 +77,7 @@ func (api *API) createFirewallSettingsWithReply(instanceID int, params []map[str
"attempt: %d, until timeout: %d", attempt, (timeout - (attempt * sleep)))
attempt++
time.Sleep(time.Duration(sleep) * time.Second)
return api.createFirewallSettingsWithReply(instanceID, params, attempt, sleep, timeout)
return api.createFirewallSettingsWithRetry(instanceID, params, attempt, sleep, timeout)
case failed["error_code"].(float64) == 40002:
return attempt, fmt.Errorf("Firewall rules validation failed due to: %s", failed["error"].(string))
}
Expand Down Expand Up @@ -133,10 +133,10 @@ func (api *API) updateFirewallSettingsWithRetry(instanceID int, params []map[str
return attempt, fmt.Errorf("Update firewall settings failed, reached timeout of %d seconds", timeout)
}

switch {
case response.StatusCode == 204:
switch response.StatusCode {
case 204:
return attempt, nil
case response.StatusCode == 400:
case 400:
switch {
case failed["error_code"] == nil:
break
Expand All @@ -150,34 +150,61 @@ func (api *API) updateFirewallSettingsWithRetry(instanceID int, params []map[str
return attempt, fmt.Errorf("Firewall rules validation failed due to: %s", failed["error"].(string))
}
}
return attempt, fmt.Errorf("Update firewall rules failed, status: %v, message: %v", response.StatusCode, failed)
return attempt, fmt.Errorf("Update firewall rules failed, status: %v, message: %v",
response.StatusCode, failed)
}

func (api *API) DeleteFirewallSettings(instanceID, sleep, timeout int) ([]map[string]interface{}, error) {
log.Printf("[DEBUG] go-api::security_firewall::delete instance id: %v, sleep: %d, timeout: %d",
instanceID, sleep, timeout)
attempt, err := api.deleteFirewallSettingsWithRetry(instanceID, 1, sleep, timeout)
if err != nil {
return nil, err
}

err = api.waitUntilFirewallConfigured(instanceID, attempt, sleep, timeout)
if err != nil {
return nil, err
}
return api.ReadFirewallSettings(instanceID)
}

func (api *API) deleteFirewallSettingsWithRetry(instanceID, attempt, sleep, timeout int) (int, error) {
var (
params [1]map[string]interface{}
failed map[string]interface{}
path = fmt.Sprintf("/api/instances/%d/security/firewall", instanceID)
)
log.Printf("[DEBUG] go-api::security_firewall::delete instance id: %v", instanceID)

// Use default firewall rule and update firewall upon delete.
params[0] = DefaultFirewallSettings()
log.Printf("[DEBUG] go-api::security_firewall::delete default firewall: %v", params[0])
response, err := api.sling.New().Put(path).BodyJSON(params).Receive(nil, &failed)

if err != nil {
return nil, err
}
if response.StatusCode != 204 {
return nil, fmt.Errorf("DeleteFirewallSettings failed, status: %v, message: %s", response.StatusCode, failed)
return attempt, err
} else if attempt*sleep > timeout {
return attempt, fmt.Errorf("Delete firewall settings failed, reached timeout of %d seconds", timeout)
}

err = api.waitUntilFirewallConfigured(instanceID, 1, sleep, timeout)
if err != nil {
return nil, err
switch response.StatusCode {
case 204:
return attempt, nil
case 400:
switch {
case failed["error_code"] == nil:
break
case failed["error_code"].(float64) == 40001:
log.Printf("[INFO] go-api::security_firewall::delete Firewall not finished configuring "+
"attempt: %d until timeout: %d", attempt, (timeout - (attempt * sleep)))
attempt++
time.Sleep(time.Duration(sleep) * time.Second)
return api.deleteFirewallSettingsWithRetry(instanceID, attempt, sleep, timeout)
case failed["error_code"].(float64) == 40002:
return attempt, fmt.Errorf("Firewall rules validation failed due to: %s", failed["error"].(string))
}
}
return api.ReadFirewallSettings(instanceID)
return attempt, fmt.Errorf("Delete firewall rules failed, status: %v, message: %v",
response.StatusCode, failed)
}

func DefaultFirewallSettings() map[string]interface{} {
Expand Down