Skip to content
This repository has been archived by the owner on Jan 23, 2025. It is now read-only.

Update error handling for firewall calls #25

Merged
merged 3 commits into from
Sep 14, 2022
Merged

Conversation

tbroden84
Copy link
Contributor

Updates error handling for creating and updating firewall request.

Utilize the new error_codes to handle specific errors and also return generic error if no match found.

Friendly reminders

  • Describe the problem / feature (ideally with meaningful commit messages)
  • Lint rules pass
  • The code changed/added as part of this pull request has been covered with tests
  • The environment (heroku config) has been updated if needed (new ENV variables)

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Sorry, something went wrong.

@tbroden84 tbroden84 requested a review from dentarg August 30, 2022 08:06
api/security_firewall.go Outdated Show resolved Hide resolved
tbroden84 and others added 3 commits September 14, 2022 08:49

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Patrik Ragnarsson <[email protected]>
@tbroden84 tbroden84 force-pushed the firewall-error-handling branch from cfdb9da to 64cccb7 Compare September 14, 2022 06:49
@tbroden84 tbroden84 merged commit ad053e3 into master Sep 14, 2022
@tbroden84 tbroden84 deleted the firewall-error-handling branch September 14, 2022 06:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants