Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ts declarations #27

Merged
merged 3 commits into from
Sep 8, 2024

Conversation

dragomirtitian
Copy link

Fixes #12. Also other general improvements.

@andersk
Copy link

andersk commented Aug 28, 2024

Consider rebasing this onto #16. (They currently conflict because #16 dedents everything to remove the incorrect declare module wrapper.)

@dragomirtitian
Copy link
Author

@andersk Sure I can do that. But do these PR have a path to being merged? #16 has been quiet for a half a year. Is @7rulnik still actively maintaining this project? I ask because we are looking at adopting this but #25 is really a show stopper since we have to reimplement fromSourceMap which is technically doable but worrying.

@7rulnik
Copy link
Owner

7rulnik commented Aug 29, 2024

@dragomirtitian hi! Well, I guess we need to define «actively».

At the start of the fork, I did not expect any further contributions other than those described in the @mraleph blog post.

But as we can see there is a demand for it. For now, this project has 29kk installs a week which is pretty huge. Because of this I kinda worried about change that I don't have time to test by myself or don't have experience to judge it.

Despite all of the above, I am open to merging this and other pull requests.

@dragomirtitian
Copy link
Author

@7rulnik That is great to hear. For sure I get the reluctance to make any big changes, and objectively there probably is no need. If it works why fix it :)

@7rulnik
Copy link
Owner

7rulnik commented Sep 8, 2024

I rebased it onto #16

@7rulnik 7rulnik merged commit bd538e4 into 7rulnik:patch-0.6.1 Sep 8, 2024
@7rulnik
Copy link
Owner

7rulnik commented Sep 8, 2024

Thanks for PR and sorry for waiting!
Published as https://www.npmjs.com/package/source-map-js/v/1.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type declarations are not null-safe
3 participants