Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix view.js to properly mark cancelled tasks #72

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CryptoRhinoGH
Copy link

Fixed view.js script to properly mark cancelled tasks compared to highlighted tasks with tasks plugin

Earlier view.js was checking if a script is cancelled or not based on task.completed == true and task.checked == true, but dv returns .checked == true in the case

Whether or not this task status is empty, meaning it has a space in its [ ] brackets
Dataview Docs - Tasks Metadata

By default cancelled task is denoted by - [-], compared to other options like - [!], - [^] and so on are incorrectly marked as cancelled.

Added check for status instead of checked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant