Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: DataView setFilter had incorrect type, partial fix #848 #849

Merged
merged 1 commit into from
Sep 27, 2023
Merged

fix: DataView setFilter had incorrect type, partial fix #848 #849

merged 1 commit into from
Sep 27, 2023

Commits on Sep 25, 2023

  1. fix: DataView setFilter had incorrect type, fixes #848 

    - `setFilter` had the incorrect type, it should be `filterFn: (item: T, args: any) => boolean` and that is inline with what `filter` callback is defined on MDN https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/filter#parameters
    @ghiscoding
    ghiscoding committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    a52765e View commit details
    Browse the repository at this point in the history