Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow for multiple css class names, fixes #795 #797

Merged
merged 4 commits into from
Jun 29, 2023
Merged

fix: allow for multiple css class names, fixes #795 #797

merged 4 commits into from
Jun 29, 2023

Commits on Jun 28, 2023

  1. fix: allow for multiple css class names (6pac#795) 

    The previous behaviour with jQuery was that anywhere a class
name was passed, jQuery allowed a space separated list of
class names.
With "classList.add" this behaviour has to be explicitly added.

I believe all cases where ".split()" is used are already guarded
against the classname not being falsy.
There were a couple of places where ".split" was used, but not
the spread operator (...). This would result in a comma separated
list of classnames being added. The assumption is that was a bug
so I have fixed those.

I haven't changed any code in "dist", I assume that is handled
as part of the release process in some way.
    @tomqwpl
    tomqwpl committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    8372558 View commit details
    Browse the repository at this point in the history

  2. fix: typo in "split" method call

    @tomqwpl
    tomqwpl committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    7a8632c View commit details
    Browse the repository at this point in the history

  3. chore: run npm minify 

    Unclear whether this is a required part of the process
    @tomqwpl
    tomqwpl committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    2d27eee View commit details
    Browse the repository at this point in the history

  4. fix: missed the actual instance I care about!

    @tomqwpl
    tomqwpl committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    f4a1267 View commit details
    Browse the repository at this point in the history