setColumns should update the global treeColumns and columns variable #665
Conversation
| columns = columnDefinitions; | ||
| } | ||
| treeColumns = new Slick.TreeColumns(columnDefinitions); | ||
| columns = treeColumns.extractColumns(); |
There was a problem hiding this comment.
we can hardly accept this PR, we actually were thinking to get rid of it, but you are trying to making it the only option. There's a long post about this in this issue #592, I still don't understand what this tree does exactly
There was a problem hiding this comment.
Whew! Just read through all of that for #592. So it looks like we never actually did get rid of TreeColumns? I do think there are much less complex ways of implementing column grouping than a tree structure, and given that the column array is a fundamental part of SlickGrid, it's best not messed with.
|
closing since code change request were not applied and we are actually trying to remove TreeColumns entirely, see PR #775 which, if merged, will be release in our upcoming Roadmap to v4.0 |
Calling
setColumnsdoes not update the global treeColumns and columns variable when there is no tree columns (e.g. flat grid). This causes a bug that the column collection cannot be updated once grid is intialized