Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sub-menu(s) to GridMenu control #868

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Conversation

ghiscoding
Copy link
Collaborator

@ghiscoding ghiscoding commented Oct 19, 2023

  • currently only works by click event on sub-menus, I tried to implement it with mouseover/mouseout but it's a lot more complex (we need to know if we are mousing over the correct sub-menu or over something else and this and that... wow just too much work)... so click should be enough for now, even though it's slightly less user friendly

TODOS

  • requires PR feat: add sub-menu(s) to CellMenu & ContextMenu plugins #867 to be merged for this PR to not fail
    • build fails because subMenuTitle and subMenuTitleCssClass were added in previous PR
  • I think createMenu() needs to be reworked and used more than once
  • add sub-menus to Grid Menu control
  • add Cypress E2E tests
  • add subMenuTitle & subMenuTitleCssClass to optionally add sub-menu title & custom styling
  • opening a sub-menu then open a sub-menu from another tree doesn't close previous sub-menu that becomes orphan

image

@ghiscoding ghiscoding changed the title feat: add sub-menu(s) to GridMenu control WIP - feat: add sub-menu(s) to GridMenu control Oct 19, 2023
- currently only works by `click` event on sub-menus, I tried to implement it with `mouseover`/`mouseout` but it's a lot more complex (we need to know if we are mousing over the correct sub-menu or over something else and this and that... wow just too much work)... so `click` should be enough for now, even though it's slightly less user friendly
@ghiscoding ghiscoding changed the title WIP - feat: add sub-menu(s) to GridMenu control feat: add sub-menu(s) to GridMenu control Oct 20, 2023
@ghiscoding ghiscoding merged commit 24f30f6 into master Oct 20, 2023
2 checks passed
@ghiscoding ghiscoding deleted the feat/gridmenu-sub-menus branch October 20, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants