-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add sub-menu(s) to CellMenu & ContextMenu plugins #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also merge command/option code since we had a lot of duplicate code to do roughly the same thing but with different list (command/options)
ghiscoding
commented
Oct 18, 2023
ghiscoding
commented
Oct 18, 2023
ghiscoding
commented
Oct 18, 2023
ghiscoding
commented
Oct 18, 2023
ghiscoding
commented
Oct 18, 2023
ghiscoding
changed the title
WIP - feat: add sub-menus to Cell Menu plugin
WIP - feat: add sub-menu(s) to CellMenu & ContextMenu plugins
Oct 18, 2023
6 tasks
5 tasks
ghiscoding
changed the title
WIP - feat: add sub-menu(s) to CellMenu & ContextMenu plugins
feat: add sub-menu(s) to CellMenu & ContextMenu plugins
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
click
event on sub-menus, I tried to implement it withmouseover
/mouseout
but it's a lot more complex (we need to know if we are mousing over the correct sub-menu or over something else and this and that... wow just too much work)... soclick
should be enough for now, even though it's slightly less user friendlyTODOS
slick-submenu
class when it's a sub-menuslick-group-level-2
& 2-addlevel="2"
attributesubMenuTitle
&subMenuTitleCssClass
to optionally add sub-menu title & custom styling