Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sub-menu(s) to CellMenu & ContextMenu plugins #867

Merged
merged 13 commits into from
Oct 20, 2023

Conversation

ghiscoding
Copy link
Collaborator

@ghiscoding ghiscoding commented Oct 18, 2023

  • also merge command/option code since we had a lot of duplicate code to do roughly the same thing but with different list (command/options)
  • currently only works by click event on sub-menus, I tried to implement it with mouseover/mouseout but it's a lot more complex (we need to know if we are mousing over the correct sub-menu or over something else and this and that... wow just too much work)... so click should be enough for now, even though it's slightly less user friendly
  • this is the 1st PR but in theory it should be easy enough to replicate for other menu plugins (GridMenu, HeaderMenu)

TODOS

  • add sub-menus to Cell Menu plugin
    • add Cypress E2E tests
  • add sub-menus to Context Menu plugin
    • add Cypress E2E tests
  • add slick-submenu class when it's a sub-menu
  • add sub-menu level number for optional custom styling
    • i.e. Grouping does it in 2 ways: 1-add slick-group-level-2 & 2-add level="2" attribute
  • verify that sub-menu(s) is always at an expected position, it seems incorrect for some sub-menus
  • add subMenuTitle & subMenuTitleCssClass to optionally add sub-menu title & custom styling
  • opening a sub-menu then open a sub-menu from another tree doesn't close previous sub-menu that becomes orphan

image

image

- also merge command/option code since we had a lot of duplicate code to do roughly the same thing but with different list (command/options)
@ghiscoding ghiscoding changed the title WIP - feat: add sub-menus to Cell Menu plugin WIP - feat: add sub-menu(s) to CellMenu & ContextMenu plugins Oct 18, 2023
@ghiscoding ghiscoding changed the title WIP - feat: add sub-menu(s) to CellMenu & ContextMenu plugins feat: add sub-menu(s) to CellMenu & ContextMenu plugins Oct 20, 2023
@ghiscoding ghiscoding merged commit 0309ec4 into master Oct 20, 2023
2 checks passed
@ghiscoding ghiscoding deleted the feat/context-sub-menus branch October 20, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants