fix: allow for multiple css class names, fixes #795 #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous behaviour with jQuery was that anywhere a class name was passed, jQuery allowed a space separated list of class names. With "classList.add" this behaviour has to be explicitly added. I believe all cases where ".split()" is used are already guarded against the classname not being falsy. There were a couple of places where ".split" was used, but not the spread operator (...). This would result in a comma separated list of classnames being added. The assumption is that was a bug so I have fixed those. I haven't changed any code in "dist", I assume that is handled as part of the release process in some way.
|
Note that currently the cypress tests don't seem to run cleanly. |
|
OK. Cypress tests run cleanly now |
Unclear whether this is a required part of the process
|
With these commits I can confirm that I can set a header button using a css class using code like: |
|
Thanks for the PR, the changes to the dist minified files wasn't necessary but that should still be fine. Thanks for the contribution. EDIT I also tested with our project and I don't see any problems, we can probably go ahead with the merge. Just remember to only change core file in the future, meaning that you don't need to modify any of the files that are in the |
ghiscoding
approved these changes
Jun 28, 2023
ghiscoding
changed the title
|
I think it's safe to merge, so I'll go ahead and merge so that I can continue with other PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous behaviour with jQuery was that anywhere a class name was passed, jQuery allowed a space separated list of class names.
With "classList.add" this behaviour has to be explicitly added.
I believe all cases where ".split()" is used are already guarded against the classname not being falsy.
There were a couple of places where ".split" was used, but not the spread operator (...). This would result in a comma separated list of classnames being added. The assumption is that was a bug so I have fixed those.
I haven't changed any code in "dist", I assume that is handled as part of the release process in some way.