Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIsappearing row with auto-height on when grid adds scroll bar to show editor #674

Closed
genyded opened this issue Apr 10, 2022 · 1 comment

Comments

@genyded
Copy link

genyded commented Apr 10, 2022

example-dynamic-filtered-with-jquery-tabs.zip

The attached aip contains a modified version of the example-dynamic-filtered-with-jquery-tabs.html file from the examples folder in your build tree. Extract it, put it into the examples folder of a copy your build tree then open/run it. If you try to edit the 'Relevance' (last) column of one of the last two rows (row 49 or 50). You should see that the entire row disappears from the grid. If you edit any of the higher up rows that do not cause the grid to scroll, then it weeks fine. This only seems to happen when editing a row that causes the grid to scroll when the editor is opened. If you turn auto-height off, the issues does not happen, but we need editable cells with auto height on. We are using v2.4.24 of the grid.

@6pac 6pac closed this as completed in 571dc12 Aug 1, 2022
@6pac
Copy link
Owner

6pac commented Aug 1, 2022

Thanks for the bug report. The solution was to prevent the grid handling the scroll event when autoheight is being used.

slick.grid.js:

function handleScroll() {
  + // autoheight does not have scrolling, but editors can trigger a scroll, which we should ignore
  + if (options.autoHeight) return;
  
  scrollTop = $viewportScrollContainerY[0].scrollTop;
  scrollLeft = $viewportScrollContainerX[0].scrollLeft;
  return _handleScroll(false);
}

this will be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants