bugfix returning reference to temporary

5had3z · Jun 20, 2024 · 4e2df1e · 4e2df1e
1 parent b1bb37f
commit 4e2df1e
Showing 1 changed file with 3 additions and 11 deletions.
diff --git a/include/data_structures/replay_interface.hpp b/include/data_structures/replay_interface.hpp
@@ -251,20 +251,12 @@ template<IsSoAType StepDataSoAType> struct ReplayDataTemplateSoA
     [[nodiscard]] auto size() const noexcept -> std::size_t { return data.size(); }
 
     /**
-     * @brief Get constant reference to replay data at step index
+     * @brief Get replay data at step index
      *
      * @param index index of replay observations
-     * @return const StepDataType&
-     */
-    [[nodiscard]] auto operator[](std::size_t index) const noexcept -> const step_type & { return data[index]; }
-
-    /**
-     * @brief Get reference to replay data at step index
-     *
-     * @param index index of replay observations
-     * @return const StepDataType&
+     * @return StepDataType
      */
-    [[nodiscard]] auto operator[](std::size_t index) noexcept -> step_type & { return data[index]; }
+    [[nodiscard]] auto operator[](std::size_t index) const noexcept -> step_type { return data[index]; }
 
     /**
      * @brief Get the unique hash ID of the replay