-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add common rarity to magic items rarity enum #332
Conversation
When can we get this merged and deployed? It's been about a week without a fix. |
@bagelbits @fergcb Could one of you approve this and merge it? It seems I missed a spot when making the GraphQL API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It'll merge in after the tests run. Good catch! |
Apparently, @fergcb's approval doesn't count. |
😢 |
🎉 This PR is included in version 2.5.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
As mentioned in #331, this fix worked great for the original error, but unfortunately there's a new one now: |
Here's PR to fix that error as well: #334 |
What does this do?
This PR fixes the issue that when quering the API using GraphQL for Magic Items and there is a magic Item with Common Rarity, the API return a 500 response because there no "Common" rarity listed on the enum for the GrapQL.
How was it tested?
Using the Apollo sandbox explorer perform the following query with the following Variables:
Query:
Variables
Is there a Github issue this is resolving?
This resolves issue #331
Was any impacted documentation updated to reflect this change?
<It's not clear if I don't update this text with relevant info>
Here's a fun image for your troubles