Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add ARTIFACT rarity to magic items rarity enum #334

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

techwraith
Copy link
Contributor

What does this do?

This PR fixes the issue that when quering the API using GraphQL for Magic Items and there is a magic Item with Common Rarity, the API return a 500 response because there no "ARTIFACT" rarity listed on the enum for the GraphQL.

How was it tested?

Using the Apollo sandbox explorer perform the following query with the following Variables:
Query:

query MagicItemsQuery($equipmentCategory: StringFilter, $order: MagicItemOrder) {
  magicItems(equipment_category: $equipmentCategory, order: $order) {
    index
    name
    desc
    rarity
    equipment_category {
      index
      name
    }
  }
}

Is there a Github issue this is resolving?

#331 (ish)

Was any impacted documentation updated to reflect this change?

N/A

Here's a fun image for your troubles

random photo - update me

Copy link
Collaborator

@bagelbits bagelbits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot that Artifact is also a rarity.

@bagelbits bagelbits enabled auto-merge (squash) September 14, 2022 04:48
@bagelbits bagelbits merged commit 628e7e3 into 5e-bits:main Sep 14, 2022
@github-actions
Copy link

🎉 This PR is included in version 2.5.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@techwraith
Copy link
Contributor Author

Thanks @bagelbits!

@bagelbits
Copy link
Collaborator

Just doing my job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants