Skip to content
This repository has been archived by the owner on Jun 5, 2023. It is now read-only.

feat(Time): Add Time Component #18

Merged
merged 23 commits into from
Sep 2, 2019
Merged

feat(Time): Add Time Component #18

merged 23 commits into from
Sep 2, 2019

Conversation

MrSwitch
Copy link
Member

Migrates the Time component from common/ui/elements/time

@diondiondion
Copy link
Member

@MrSwitch Is the component meant to work this way, i.e. without specifying how many seconds/minutes ago?

image

The Readme could be a bit clearer about how the dates are formatted, i.e. is a localised date format used or is that hard-coded?

@diondiondion
Copy link
Member

I'd also like components in base5-ui to not use deprecated lifecycle methods, so a rewrite as a functional component (or using getDerivedStateFromProps) would be nice; but I can also do that if you don't get around to it. Timeouts in hooks can be tricky.

@MrSwitch MrSwitch requested a review from diondiondion August 30, 2019 17:05
@MrSwitch
Copy link
Member Author

@MrSwitch Is the component meant to work this way, i.e. without specifying how many seconds/minutes ago?

Well i copied what we had, but i've improved it to show the number of minutes. I consiously didn't want a ticking clock because that feels like a bad UI.

The Readme could be a bit clearer about how the dates are formatted, i.e. is a localised date format used or is that hard-coded?

I've changed this in the revision, the dates and times are localised, however the periods 1 minute ago, seconds ago are still in English, it'll be hard to translate that without a library.

@MrSwitch MrSwitch changed the title WIP: feat(Time): Add Time Component feat(Time): Add Time Component Aug 31, 2019
@MrSwitch MrSwitch requested review from diondiondion and removed request for diondiondion September 2, 2019 15:31
@diondiondion diondiondion merged commit 56aedb7 into master Sep 2, 2019
@diondiondion diondiondion deleted the time-component branch September 2, 2019 16:37
MrSwitch pushed a commit that referenced this pull request Sep 2, 2019
# [3.11.0](v3.10.0...v3.11.0) (2019-09-02)

### Features

* **Time:** Add Time Component ([#18](#18)) ([56aedb7](56aedb7))
@MrSwitch
Copy link
Member Author

MrSwitch commented Sep 2, 2019

🎉 This PR is included in version 3.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants